Is the DBSCAN pseudocode shown on wikipedia page flawed?












0












$begingroup$


Referenced from this paper, the follow pseudocode is shown on the DBSCAN wikipedia page:



DBSCAN(DB, distFunc, eps, minPts) {
C = 0 /* Cluster counter */
for each point P in database DB {
if label(P) ≠ undefined then continue /* Previously processed in inner loop */
Neighbors N = RangeQuery(DB, distFunc, P, eps) /* Find neighbors */
if |N| < minPts then { /* Density check */
label(P) = Noise /* Label as Noise */
continue
}
C = C + 1 /* next cluster label */
label(P) = C /* Label initial point */
Seed set S = N {P} /* Neighbors to expand */
for each point Q in S { /* Process every seed point */
if label(Q) = Noise then label(Q) = C /* Change Noise to border point */
if label(Q) ≠ undefined then continue /* Previously processed */
label(Q) = C /* Label neighbor */
Neighbors N = RangeQuery(DB, distFunc, Q, eps) /* Find neighbors */
if |N| ≥ minPts then { /* Density check */
S = S ∪ N /* Add new neighbors to seed set */
}
}
}
}


The problem I found with this code is that it does not visit points which has been processed (marked as noise or part of a cluster); this is unsafe. For example, if I have four points as shown in the picture below, where the points are indicated by blue circles and the number above each point is its sequence in the database DB.



enter image description here



Given distFunc = EuclideanDist; eps = 1.01; minPts = 2;, with the above code, I think I will get two clusters: {Point_1, Point_3} and {Point_2, Point_4}. However, isn't the correct answer be a single cluster formed with all four points?



Am I correct or wrong?









share







New contributor




Anthony is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    Referenced from this paper, the follow pseudocode is shown on the DBSCAN wikipedia page:



    DBSCAN(DB, distFunc, eps, minPts) {
    C = 0 /* Cluster counter */
    for each point P in database DB {
    if label(P) ≠ undefined then continue /* Previously processed in inner loop */
    Neighbors N = RangeQuery(DB, distFunc, P, eps) /* Find neighbors */
    if |N| < minPts then { /* Density check */
    label(P) = Noise /* Label as Noise */
    continue
    }
    C = C + 1 /* next cluster label */
    label(P) = C /* Label initial point */
    Seed set S = N {P} /* Neighbors to expand */
    for each point Q in S { /* Process every seed point */
    if label(Q) = Noise then label(Q) = C /* Change Noise to border point */
    if label(Q) ≠ undefined then continue /* Previously processed */
    label(Q) = C /* Label neighbor */
    Neighbors N = RangeQuery(DB, distFunc, Q, eps) /* Find neighbors */
    if |N| ≥ minPts then { /* Density check */
    S = S ∪ N /* Add new neighbors to seed set */
    }
    }
    }
    }


    The problem I found with this code is that it does not visit points which has been processed (marked as noise or part of a cluster); this is unsafe. For example, if I have four points as shown in the picture below, where the points are indicated by blue circles and the number above each point is its sequence in the database DB.



    enter image description here



    Given distFunc = EuclideanDist; eps = 1.01; minPts = 2;, with the above code, I think I will get two clusters: {Point_1, Point_3} and {Point_2, Point_4}. However, isn't the correct answer be a single cluster formed with all four points?



    Am I correct or wrong?









    share







    New contributor




    Anthony is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      Referenced from this paper, the follow pseudocode is shown on the DBSCAN wikipedia page:



      DBSCAN(DB, distFunc, eps, minPts) {
      C = 0 /* Cluster counter */
      for each point P in database DB {
      if label(P) ≠ undefined then continue /* Previously processed in inner loop */
      Neighbors N = RangeQuery(DB, distFunc, P, eps) /* Find neighbors */
      if |N| < minPts then { /* Density check */
      label(P) = Noise /* Label as Noise */
      continue
      }
      C = C + 1 /* next cluster label */
      label(P) = C /* Label initial point */
      Seed set S = N {P} /* Neighbors to expand */
      for each point Q in S { /* Process every seed point */
      if label(Q) = Noise then label(Q) = C /* Change Noise to border point */
      if label(Q) ≠ undefined then continue /* Previously processed */
      label(Q) = C /* Label neighbor */
      Neighbors N = RangeQuery(DB, distFunc, Q, eps) /* Find neighbors */
      if |N| ≥ minPts then { /* Density check */
      S = S ∪ N /* Add new neighbors to seed set */
      }
      }
      }
      }


      The problem I found with this code is that it does not visit points which has been processed (marked as noise or part of a cluster); this is unsafe. For example, if I have four points as shown in the picture below, where the points are indicated by blue circles and the number above each point is its sequence in the database DB.



      enter image description here



      Given distFunc = EuclideanDist; eps = 1.01; minPts = 2;, with the above code, I think I will get two clusters: {Point_1, Point_3} and {Point_2, Point_4}. However, isn't the correct answer be a single cluster formed with all four points?



      Am I correct or wrong?









      share







      New contributor




      Anthony is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Referenced from this paper, the follow pseudocode is shown on the DBSCAN wikipedia page:



      DBSCAN(DB, distFunc, eps, minPts) {
      C = 0 /* Cluster counter */
      for each point P in database DB {
      if label(P) ≠ undefined then continue /* Previously processed in inner loop */
      Neighbors N = RangeQuery(DB, distFunc, P, eps) /* Find neighbors */
      if |N| < minPts then { /* Density check */
      label(P) = Noise /* Label as Noise */
      continue
      }
      C = C + 1 /* next cluster label */
      label(P) = C /* Label initial point */
      Seed set S = N {P} /* Neighbors to expand */
      for each point Q in S { /* Process every seed point */
      if label(Q) = Noise then label(Q) = C /* Change Noise to border point */
      if label(Q) ≠ undefined then continue /* Previously processed */
      label(Q) = C /* Label neighbor */
      Neighbors N = RangeQuery(DB, distFunc, Q, eps) /* Find neighbors */
      if |N| ≥ minPts then { /* Density check */
      S = S ∪ N /* Add new neighbors to seed set */
      }
      }
      }
      }


      The problem I found with this code is that it does not visit points which has been processed (marked as noise or part of a cluster); this is unsafe. For example, if I have four points as shown in the picture below, where the points are indicated by blue circles and the number above each point is its sequence in the database DB.



      enter image description here



      Given distFunc = EuclideanDist; eps = 1.01; minPts = 2;, with the above code, I think I will get two clusters: {Point_1, Point_3} and {Point_2, Point_4}. However, isn't the correct answer be a single cluster formed with all four points?



      Am I correct or wrong?







      clustering





      share







      New contributor




      Anthony is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Anthony is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Anthony is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 3 mins ago









      AnthonyAnthony

      1011




      1011




      New contributor




      Anthony is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Anthony is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Anthony is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["$", "$"], ["\\(","\\)"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "557"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Anthony is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fdatascience.stackexchange.com%2fquestions%2f45844%2fis-the-dbscan-pseudocode-shown-on-wikipedia-page-flawed%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Anthony is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Anthony is a new contributor. Be nice, and check out our Code of Conduct.













          Anthony is a new contributor. Be nice, and check out our Code of Conduct.












          Anthony is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Data Science Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fdatascience.stackexchange.com%2fquestions%2f45844%2fis-the-dbscan-pseudocode-shown-on-wikipedia-page-flawed%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Aikido

          Tivadar Csontváry Kosztka

          Metroo de Marsejlo